Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Test clang-tidy --checks performance-move-const-arg #29931

Closed
wants to merge 1 commit into from
Closed

[RFC] Test clang-tidy --checks performance-move-const-arg #29931

wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 21, 2020

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 21, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard fwyzard mentioned this pull request May 21, 2020
Closed
This was referenced May 21, 2020
Merged
Closed
@cmsbuild
Copy link
Contributor

-code-checks

ERROR: Build errors found during clang-tidy run.

DataFormats/Common/interface/Wrapper.h:92:80: error: no matching constructor for initialization of 'MkFitInputWrapper' [clang-diagnostic-error]
  Wrapper<T>::Wrapper(Emplace, Args&&... args) : WrapperBase(), present(true), obj(std::forward<Args>(args)...) {}
                                                                               ^
FWCore/Framework/interface/Event.h:448:43: note: in instantiation of function template specialization 'edm::Wrapper<MkFitInputWrapper>::Wrapper<MkFitHitIndexMap, std::vector<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> >, std::allocator<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> > > >, std::vector<mkfit::Track, std::allocator<mkfit::Track> >, mkfit::LayerNumberConverter &>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

This was referenced May 21, 2020
Closed
Closed
Closed
This was referenced Jun 4, 2020
Merged
Merged
@slava77
Copy link
Contributor

slava77 commented Jun 10, 2020

+1
(no significant objections/concerns)

it looks like this better not be automated

@cmsbuild cmsbuild mentioned this pull request Jun 16, 2020
Merged
@santocch
Copy link

+1

@pohsun
Copy link

pohsun commented Jun 20, 2020

+1

@alja
Copy link
Contributor

alja commented Jun 21, 2020

+1

@mrodozov
Copy link
Contributor

mrodozov commented Jul 1, 2020

@fwyzard what we wanted to do with this, could you remind me

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 1, 2020

This should go in - it's mostly signed, and it actually helped find bugs in our code.

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 1, 2020

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 1, 2020

+upgrade

@mrodozov mrodozov mentioned this pull request Jul 2, 2020
Closed
This was referenced Jul 9, 2020
Merged
Merged
Closed
@fwyzard fwyzard closed this Jul 14, 2020
@fwyzard fwyzard deleted the clang-tidy-performance-move-const-arg branch July 14, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

@Dr15Jones Dr15Jones Dr15Jones left review comments

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
alca-approved analysis-approved code-checks-approved comparison-available core-pending db-pending dqm-approved fastsim-approved generators-approved geometry-approved heterogeneous-pending l1-pending orp-pending pending-signatures reconstruction-approved simulation-approved tests-approved upgrade-approved visualization-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.